Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow slider card to specify kind of outcome value #19

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Nov 26, 2024

Sometimes only a specific kind of outcome value should show on the slider. Allow the developer to specify the kind

@cbaker6 cbaker6 merged commit 64d03f0 into main Nov 26, 2024
4 checks passed
@cbaker6 cbaker6 deleted the improveSliderValues branch November 26, 2024 18:48
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 8.28%. Comparing base (02ea2bb) to head (e026c75).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/Cards/iOS/SliderLog/SliderLogTaskViewModel.swift 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #19      +/-   ##
========================================
+ Coverage   7.50%   8.28%   +0.78%     
========================================
  Files         36      36              
  Lines       1319    1689     +370     
========================================
+ Hits          99     140      +41     
- Misses      1220    1549     +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant