Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve Hashable conformance of OCKAnyEvent #29

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Dec 14, 2024

Continuation of #28

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 205 lines in your changes missing coverage. Please review.

Project coverage is 5.16%. Comparing base (4d0fcc6) to head (f8549f9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tEssentials/Extensions/OCKAnyEvent+Equatable.swift 0.00% 65 Missing ⚠️
...itEssentials/Extensions/OCKAnyEvent+Hashable.swift 0.00% 24 Missing ⚠️
...sentials/Extensions/OCKOutcomeValue+Hashable.swift 0.00% 23 Missing ⚠️
...tials/Extensions/OCKScheduleElement+Hashable.swift 0.00% 16 Missing ⚠️
...reKitEssentials/Extensions/OCKStore+Hashable.swift 0.00% 13 Missing ⚠️
...s/Extensions/CareStoreFetchedResult+Hashable.swift 0.00% 11 Missing ⚠️
...ources/CareKitEssentials/Extensions/OCKStore.swift 0.00% 10 Missing ⚠️
...entials/Extensions/OCKBiologicalSex+Hashable.swift 0.00% 9 Missing ⚠️
...Essentials/Cards/Shared/CareKitEssentialView.swift 0.00% 6 Missing ⚠️
...entials/Extensions/OCKScheduleEvent+Hashable.swift 0.00% 6 Missing ⚠️
... and 9 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #29      +/-   ##
========================================
- Coverage   5.64%   5.16%   -0.48%     
========================================
  Files         48      61      +13     
  Lines       2481    2711     +230     
========================================
  Hits         140     140              
- Misses      2341    2571     +230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit 1d46c40 into main Dec 14, 2024
6 checks passed
@cbaker6 cbaker6 deleted the improveHashable branch December 14, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant