Allow to cancel connect() operations when using io_uring #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Whe using io_uring we can in fact cancel a connect() operation by just closing the underyling fd. Modifications: Don't mark the promise as uncancellable before issue the non-blocking connect() call Add comment to explain code Result: Related to netty/netty#13843 and netty/netty#13849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Whe using io_uring we can in fact cancel a connect() operation by just closing the underyling fd.
Modifications:
Don't mark the promise as uncancellable before issue the non-blocking connect() call Add comment to explain code
Result:
Related to netty/netty#13843 and netty/netty#13849