Add encrypt_type9 function to netutils.password #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest option '--no-cov' causes pytest to crash if pytest-cov plugin not installed add 'cryptography' to optional dependencies cisco type 9 passwords use the scrypt key derivation function, as implemented in the cryptography package implement `encrypt_type9` function add test for `encrypt_type9` function add `encrypt_type9` to jinja filters mapping run `development_scripts.py` to update docs improve encrypt_type9 salt generator salt generator using base85 may produce salt which includes '$'. The `get_hash_salt` function will not be able to reliably extract the salt from any hash produced using this generator switches to a `secrets`-based salt generator implement `compare_type9` function add tests for `compare_type9` function update jinja filter mapping and docs replace scrypt KDF implementation remove dependence on `cryptography` package simplify salt generator update test data update test suite with input/output derived from real switch config add cryptography as an optional dependency make scrypt implementation compatible with more python versions clean up base64 encoding scheme in `encrypt_type9` lint `password.py`
abates
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
jeffkala
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #96