Updates parsers for issues 414, 415, and 422 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qduk
requested review from
itdependsnetworks,
jeffkala and
abates
as code owners
This was
linked to
issues
Dec 19, 2023
itdependsnetworks
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
huaweias we had it incorrect. Example usage of huawei network drivercisco_xewhere applicable.cisco_xrper thisBecause
cisco_xemaps to the same platform in some reverse mappings, I popped that key out for the reverse to non-reverse mapping test. I'd definitely the review on this as I want to make sure I'm not missing anything. (Plus these mappers are always a little confusing.)