-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task unaware xor vs rxor random forest bootstrap experiment #544
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black
formatting needed. Also the file name is quite long. You can make it shorter.
Please do not print 10,20,30... in the notebook. |
Fixed |
Fixed |
Nope~ |
Are both files still formatted incorrectly? I ran black on the functions file and jblack on the notebook. Edit: I just reran both, I think there were some changes made to the notebook so I reuploaded that. Please, let me know if there is still a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kfenggg Check not passed. You can take a look yourself. black
works for jupyter
notebooks natively. Other packages will not pass.
Codecov Report
@@ Coverage Diff @@
## staging #544 +/- ##
========================================
Coverage 90.09% 90.09%
========================================
Files 7 7
Lines 404 404
========================================
Hits 364 364
Misses 40 40 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @kfenggg Actually you can make the title shorter and more consistent as other XOR experiments: https://proglearn.neurodata.io/experiments/xor_rxor_exp.html. You should also add subsections to make the tutorial more readable.
@jdey4 your thoughts?
More consistent with other XOR experiments.
more consistent with other XOR experiments
I think, this PR needs more work to publish it in the main or staging branch. But this is good for doing the grading. We can save the PR in a separate branch. |
Reference issue
Experiment for task unaware learning.
Type of change
Add jupyter notebook containing experiment and functions file to run the experiment.
What does this implement/fix?
Adds an experiment that explores when xor and rxor are different enough to train a new random forest.
Additional information