DO NOT MERGE: Compute ext-service OpenTelemetry golden metrics from metrics instead of spans #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
approved these changes
Nov 11, 2024
entityBot
approved these changes
Nov 11, 2024
jack-berg
commented
Nov 11, 2024
| select: rate(count(*), 1 minute) | ||
| from: Span | ||
| where: span.kind LIKE 'server' OR span.kind LIKE 'consumer' OR kind LIKE 'server' OR kind LIKE 'consumer' | ||
| select: rate(count(%.server%duration), 1 minute) |
There was a problem hiding this comment.
Do we expect any issues defining golden metrics with wildcard syntax?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jack-berg
commented
Nov 11, 2024
| select: average(duration.ms) | ||
| from: Span | ||
| where: span.kind LIKE 'server' OR span.kind LIKE 'consumer' OR kind LIKE 'server' OR kind LIKE 'consumer' | ||
| select: average(convert(%.server%duration, unit OR 's', 'ms')) |
There was a problem hiding this comment.
Do we expect any issues defining golden metrics with the convert function?
jack-berg
force-pushed
the
ext-service-golden-metrics
branch
from
2da2596 to
2e5b712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the same query definitions which drive the OpenTelemetry metrics-based UI view.