Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community-containers: Add NocoDB #4835

Merged
merged 7 commits into from
Jun 17, 2024
Merged

community-containers: Add NocoDB #4835

merged 7 commits into from
Jun 17, 2024

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Jun 15, 2024

Do you prefer that I put the original image, or do it manually?

By doing it manually, I verify that an update is not breaking. And when Nextcloud Tables V2 is here, I will put the original image back.

Signed-off-by: Jean-Yves <[email protected]>
@docjyJ docjyJ added 3. to review Waiting for reviews enhancement New feature or request labels Jun 15, 2024
@docjyJ docjyJ self-assigned this Jun 15, 2024
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ docjyJ requested a review from szaimen June 15, 2024 14:33
Signed-off-by: Jean-Yves <[email protected]>
@szaimen szaimen added this to the next milestone Jun 16, 2024
@szaimen
Copy link
Collaborator

szaimen commented Jun 17, 2024

Do you prefer that I put the original image, or do it manually?

Both are fine...

By doing it manually, I verify that an update is not breaking. And when Nextcloud Tables V2 is here, I will put the original image back.

Sounds like a plan :)

Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

Some comments below...

community-containers/nocodb/readme.md Outdated Show resolved Hide resolved
community-containers/nocodb/readme.md Outdated Show resolved Hide resolved
docjyJ and others added 2 commits June 17, 2024 11:53
Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Co-authored-by: Simon L. <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Jun 17, 2024

Sorry for the copy and paste, I should have done a crtl+f ^^'.

@szaimen
Copy link
Collaborator

szaimen commented Jun 17, 2024

Sorry for the copy and paste, I should have done a crtl+f ^^'.

all good!

Signed-off-by: Jean-Yves <[email protected]>
@docjyJ
Copy link
Collaborator Author

docjyJ commented Jun 17, 2024

Both are fine...

I prefer not to lose any data due to an update.

@szaimen
Copy link
Collaborator

szaimen commented Jun 17, 2024

Both are fine...

I prefer not to lose any data due to an update.

all right 👍

@szaimen szaimen changed the title Add NocoDB community-containers: Add NocoDB Jun 17, 2024
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot! :)

@szaimen szaimen merged commit dbbbc76 into main Jun 17, 2024
4 checks passed
@szaimen szaimen deleted the dev/docjyj/nocodb branch June 17, 2024 11:55
@szaimen
Copy link
Collaborator

szaimen commented Jun 25, 2024

This is now released with v9.1.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

@docjyJ
Copy link
Collaborator Author

docjyJ commented Jun 26, 2024

Tested in local with Podman.
Login and webUI work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants