Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a setting for the default calendar url #5790

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Feb 21, 2024

@st3iny st3iny added 2. developing Work in progress enhancement New feature request labels Feb 21, 2024
@st3iny st3iny self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 2.50000% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 24.13%. Comparing base (5a45f89) to head (7a307bb).
Report is 29 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/Settings.vue 0.00% 25 Missing ⚠️
src/store/principals.js 0.00% 6 Missing ⚠️
src/store/calendarObjects.js 0.00% 4 Missing ⚠️
src/components/Shared/CalendarPicker.vue 0.00% 3 Missing ⚠️
src/store/calendars.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5790      +/-   ##
============================================
- Coverage     24.19%   24.13%   -0.07%     
  Complexity      423      423              
============================================
  Files           243      243              
  Lines         11005    11038      +33     
  Branches       1824     1833       +9     
============================================
+ Hits           2663     2664       +1     
- Misses         8342     8374      +32     
Flag Coverage Δ
javascript 15.07% <2.50%> (-0.05%) ⬇️
php 61.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny force-pushed the feat/default-calendar branch from 3bfa8c8 to c130fad Compare February 28, 2024 12:52
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it requires nextcloud/server#43745, shouldn't this only be showed on NC 29+ ?

@st3iny
Copy link
Member Author

st3iny commented Feb 28, 2024

Good catch! I'll add a version check.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Co-authored-by: Lukas Boersma <[email protected]>
Co-authored-by: szaimen <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny force-pushed the feat/default-calendar branch from 70695f9 to 7a307bb Compare February 29, 2024 09:24
@st3iny st3iny enabled auto-merge February 29, 2024 09:24
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 29, 2024
@st3iny st3iny merged commit 21e0c08 into main Feb 29, 2024
38 of 40 checks passed
@st3iny st3iny deleted the feat/default-calendar branch February 29, 2024 09:51
@Sebastian-Roth
Copy link

Thanks to everyone involved for adding this feature. I just started to use NectCloud Calendar and have exact that situation where I don't want to have the personal calendar as default.

Unfortunately the setting does not work as expected. Not sure if this is the right place to report this but I will give it a go. We use a shared calendar as a group. The calendar was created by the NextCloud admin user and made available to a group of people (group defined in our NextCloud). People see the shared calendar and add events but don't seem to be able to set it as default calendar - see screenshots below. Admin is able to set this shared calendar as default but still is not used on new events.

NextCloud Server version: 30.0.2
NextCloud Calendar version: 5.0.8

  1. Issue - default calendar dropdown missing for shared calendar:
    user-setting-not-available

  2. Issue - default calendar set but new events still use the personal calendar as default:
    admin-setting-available-but-not-working

@st3iny
Copy link
Member Author

st3iny commented Dec 23, 2024

@Sebastian-Roth Thanks for the report. Yes, this is working as intended. Please refer to #5996 and #5942 for some more information.

TL;DR: Some users were confused by the changed default option in the calendar picker as there are some restrictions on which calendars can be picked as the default calendar picker vs in the event calendar picker.

Perhaps someone could investigate if can revert the revert now as the support for shared calendars in the backend has been improved since.

A note for the future: Please open a new ticket and reference related pull requests and tickets there. Posting in PRs pings a lot of (unrelated) people and sometimes is lost as the pull request is already closed and some people might skip the notification. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defining a default calendar
6 participants