Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable5.0] Fix calendar lists not being orderable any more #6556

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Dec 9, 2024

Backport of PR #6536

@backportbot backportbot bot requested a review from GVodyanov December 9, 2024 19:24
@backportbot backportbot bot added the 3. to review Waiting for reviews label Dec 9, 2024
@backportbot backportbot bot added this to the v5.0.2 milestone Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 15.40%. Comparing base (4d5328f) to head (7877628).
Report is 5 commits behind head on stable5.0.

Files with missing lines Patch % Lines
src/components/AppNavigation/CalendarList.vue 0.00% 17 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           stable5.0    #6556      +/-   ##
=============================================
- Coverage      15.42%   15.40%   -0.03%     
=============================================
  Files            206      206              
  Lines           9444     9458      +14     
  Branches        2195     2196       +1     
=============================================
  Hits            1457     1457              
- Misses          7669     7683      +14     
  Partials         318      318              
Flag Coverage Δ
javascript 15.40% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst
Copy link
Member

@GVodyanov the commit action is complaining because we are backporting a feat. Only fixes can be backported. Can you please amend and fix the conventional commit message?

@GVodyanov
Copy link
Contributor

@ChristophWurst can we merge anyway?

@st3iny st3iny force-pushed the backport/6536/stable5.0 branch from 5c4654e to 7877628 Compare December 28, 2024 12:40
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse compatibility has been fixed on stable5.0 in the meantime.

@st3iny st3iny added bug Feature: Calendar list 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 28, 2024
@st3iny st3iny merged commit 415c089 into stable5.0 Dec 28, 2024
28 of 30 checks passed
@st3iny st3iny deleted the backport/6536/stable5.0 branch December 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Calendar list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants