Skip to content

Commit

Permalink
Merge pull request #4270 from nextcloud/backport/4269/stable28
Browse files Browse the repository at this point in the history
[stable28] fix: remove deprecated `title` parameter
  • Loading branch information
elzody authored Nov 27, 2024
2 parents d7f64dc + 5ff6037 commit 0353447
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions src/helpers/url.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const getWopiSrc = (fileId) => {
return wopiurl
}

const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, target = undefined }) => {
const getWopiUrl = ({ fileId, readOnly, closeButton, revisionHistory, target = undefined }) => {
// Only set the revision history parameter if the versions app is enabled
revisionHistory = revisionHistory && window?.oc_appswebroots?.files_versions

Expand All @@ -55,7 +55,6 @@ const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, tar
// https://<loolwsd-server>:9980/hosting/discovery
return Config.get('urlsrc')
+ 'WOPISrc=' + encodeURIComponent(getWopiSrc(fileId))
+ '&title=' + encodeURIComponent(title)
+ '&lang=' + languageToBCP47()
+ (closeButton ? '&closebutton=1' : '')
+ (revisionHistory ? '&revisionhistory=1' : '')
Expand Down
1 change: 0 additions & 1 deletion src/view/Office.vue
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,6 @@ export default {
// Generate form and submit to the iframe
const action = getWopiUrl({
fileId: fileid + '_' + loadState('richdocuments', 'instanceId', 'instanceid') + (version > 0 ? '_' + version : ''),
title: this.filename,
readOnly: version > 0,
revisionHistory: !this.isPublic,
closeButton: !Config.get('hideCloseButton'),
Expand Down

0 comments on commit 0353447

Please sign in to comment.