Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated title parameter #4269

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Nov 25, 2024

  • Target version: main

Summary

This resolves an issue of being unable to open a document if the file name has a % in it. This parameter is also not used anymore; therefore consider this another legacy cleanup of sorts :)

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody self-assigned this Nov 25, 2024
@elzody elzody changed the title [WIP] fix: percent in file name fix: remove deprecated title parameter Nov 26, 2024
@elzody elzody added the 3. to review Ready to be reviewed label Nov 26, 2024
@elzody elzody marked this pull request as ready for review November 26, 2024 17:51
@elzody elzody requested a review from juliusknorr as a code owner November 26, 2024 17:51
@elzody
Copy link
Contributor Author

elzody commented Nov 26, 2024

/backport to stable30

@elzody
Copy link
Contributor Author

elzody commented Nov 26, 2024

/backport to stable29

@elzody
Copy link
Contributor Author

elzody commented Nov 26, 2024

/backport to stable28

@juliusknorr juliusknorr merged commit cae21db into main Nov 26, 2024
54 checks passed
@juliusknorr juliusknorr deleted the fix/percent-in-file-name branch November 26, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants