Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the remote font config setting a bit #4273

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

timar
Copy link
Member

@timar timar commented Nov 26, 2024

Some people test Nextcloud and Collabora Online without setting up SSL. For security reasons, Collabora Online production builds refuse to load remote configuration via http://. It is possible to use http:// only with debug builds, that users build for themselves. The feature simply does not work, when someone tries http:// with a production build, only logs will tell "Remote config url should only use HTTPS protocol"

Some people test Nextcloud and Collabora Online without setting up SSL.
For security reasons, Collabora Online production builds refuse to load
remote configuration via http://. It is possible to use http:// only
with debug builds, that users build for themselves. The feature simply
does not work, when someone tries http:// with a production build,
only logs will tell "Remote config url should only use HTTPS protocol"

Signed-off-by: Andras Timar <[email protected]>
@juliusknorr juliusknorr merged commit e4cadf3 into main Nov 27, 2024
53 checks passed
@juliusknorr juliusknorr deleted the private/timar/remotefontconfig branch November 27, 2024 07:43
@juliusknorr juliusknorr added the bug Something isn't working label Nov 27, 2024
@juliusknorr
Copy link
Member

/backport to stable30

@juliusknorr
Copy link
Member

/backport to stable29

@juliusknorr
Copy link
Member

/backport to stable28

Copy link

backportbot bot commented Nov 27, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/4273/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7039d7e5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4273/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants