Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly get empty template for direct editing #4335

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 13, 2024

Fix #4313

Follow up to #4101 as my cypress test did not assert that the document was loaded, when doing so the test was still failing. It turned out that i used the wrong method to get the template file which would work when I manually tested with user defined templates but not with the default empty template files.

@juliusknorr juliusknorr requested a review from elzody as a code owner December 13, 2024 11:06
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Dec 13, 2024
@juliusknorr juliusknorr self-assigned this Dec 13, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@juliusknorr juliusknorr merged commit 43df790 into main Dec 18, 2024
73 checks passed
@juliusknorr juliusknorr deleted the fix/template-direct branch December 18, 2024 15:57
@juliusknorr
Copy link
Member Author

/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable30

@juliusknorr
Copy link
Member Author

/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable29

@juliusknorr
Copy link
Member Author

/backport a33d37f,cf83444010bc42d98966bfed3d1160aae4785876,cb664d63be40284f44a45ae4c2c35f6a67ad9b04 to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed backport-request bug Something isn't working
Projects
Status: ☑️ Done
2 participants