Merge pull request #1867 from nextcloud/backport/1865/stable20

[stable20] Fix CallViewController present issue
nextcloud · Nov 6, 2024 · ca0ba1d · ca0ba1d
2 parents 945e71b + 75a2a0b
commit ca0ba1d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/NextcloudTalk/NCRoomsManagerExtensions.swift b/NextcloudTalk/NCRoomsManagerExtensions.swift
@@ -24,8 +24,10 @@ import Foundation
 
         // Check if we try to join a room, we're still trying to leave
         if self.isLeavingRoom(withToken: token) {
-            self.leavingRoomToken = nil
             self.leaveRoomTask?.cancel()
+
+            self.leaveRoomTask = nil
+            self.leavingRoomToken = nil
         }
 
         self.joinRoomHelper(token, forCall: call)

diff --git a/NextcloudTalk/NCSplitViewController.swift b/NextcloudTalk/NCSplitViewController.swift
@@ -67,10 +67,9 @@
     }
 
     override func present(_ viewControllerToPresent: UIViewController, animated flag: Bool, completion: (() -> Void)? = nil) {
-        self.internalExecuteAfterTransition {
-            if !viewControllerToPresent.isBeingPresented {
-                super.present(viewControllerToPresent, animated: flag, completion: completion)
-            }
+        // Don't use internalExecuteAfterTransition here as that might interfere with presenting the CallViewController from CallKit/Background
+        if !viewControllerToPresent.isBeingPresented {
+            super.present(viewControllerToPresent, animated: flag, completion: completion)
         }
     }