Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headless release (onescript) #5569

Merged

Conversation

tom-seqera
Copy link
Contributor

An alternative approach to a headless release process (#5554) which puts all the whole process into a single script, run from within the build.yml Github Action

@tom-seqera tom-seqera mentioned this pull request Dec 4, 2024
@tom-seqera tom-seqera force-pushed the headless-release-onescript branch from 23a5316 to 5ad07c4 Compare December 5, 2024 09:29
@bentsherman
Copy link
Member

This one was the least preferred in our weekly meeting

@bentsherman bentsherman added the github actions Pull requests that update GitHub Actions code label Dec 9, 2024
@pditommaso pditommaso marked this pull request as ready for review December 10, 2024 18:59
@pditommaso
Copy link
Member

Agree

@pditommaso pditommaso merged commit 1b3bfea into nextflow-io:headless-release Dec 10, 2024
17 checks passed
@bentsherman
Copy link
Member

I said this one was the least preferred 😅

@pditommaso
Copy link
Member

LOL, i've skipped "least". My rationale is that's it's better decoupled from GH.

@bentsherman
Copy link
Member

well, as long as you are happy with the changes, doesn't matter to me which one we use

@tom-seqera
Copy link
Contributor Author

The main weakness of this approach is that it's entirely embedded in the build.yml Github workflow.

This is fine for the moment. In the future though - as we work to automate more of the remaining manual steps - we'll likely want to pull it out into its own Github workflow.

@pditommaso
Copy link
Member

Indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants