Add MPI support to ParaGrid #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
TomMelt
force-pushed
the
melt-mpi-paragrid
branch
2 times, most recently
from
eb415e0 to
d762660
Compare
TomMelt
changed the title
TomMelt
requested review from
timspainNERSC,
jwallwork23,
einola and
MarionBWeinzierl
jwallwork23
reviewed
Jun 12, 2024
TomMelt
force-pushed
the
melt-mpi-paragrid
branch
from
22444e2 to
36fa303
Compare
timspainNERSC
requested changes
Jul 16, 2024
core/src/include/ModelArray.hpp
Outdated
Comment on lines
57
to
79
| struct DimensionSpec { | ||
| std::string name; | ||
| std::string altName; | ||
| size_t length; | ||
| size_t global_length; | ||
| size_t local_length; | ||
| size_t start; | ||
| }; |
There was a problem hiding this comment.
Consider adding setters for the new class variables. Setting one member seems fine, but when several are set together (e.g. ModelArray.cpp L211 ff), keeping this with the class itself is preferred.
There was a problem hiding this comment.
Do you mean that you want separate setters for each variable e.g., setDimensionLocalLength, setDimensionGlobalLength?
And by keeping with the class do you mean in the header file i.e., core/src/include/ModelArray.hpp?
There was a problem hiding this comment.
Thanks @timspainNERSC , this has now been resolved by f22b88f
|
As stated in the README, we follow WebKit style |
TomMelt
force-pushed
the
melt-mpi-paragrid
branch
3 times, most recently
from
5c38bc5 to
eabb9b1
Compare
12 tasks
TomMelt
force-pushed
the
melt-mpi-paragrid
branch
from
50e170b to
eb2d3f4
Compare
timspainNERSC
approved these changes
Aug 21, 2024
add global_length, local_length, and start variables to `DimensionSpec` add logic to assign local dims and start in ParaGridIO update ParaGrid_test.cpp to handle MPI test wip: currently only runs for 1 MPI rank
add MPI backend and associated test for the IO functionality (get/dump model state) This currently passes but I still need to add MPI interface for the dynamics
* add mpi to ParaGridIO.cpp * finish mpi test cases for ParaGrid_test.cpp * reinstate ConfigOutput_test.cpp for MPI builds * update core/test/CMakeLists.txt to build tests and required input files
parallelize ERA5Atm_test and TOPAZOcn_test update CMakeLists.txt to only build MPI tests when MPI is enabled only test explicitly using mpi doctest will be built and run under MPI test run
`ModelArray::definedDimensions` were not set correctly. This commit sets default global size, local size and start position for each dimension
time is now the first dimension e.g., `var(time, ydim, xdim)`
TomMelt
force-pushed
the
melt-mpi-paragrid
branch
from
eb2d3f4 to
1ec385a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MPI support to ParaGrid
closes #534
closes #454
closes #448
Task List
make_init_para24x30.pyto use new DG data layout and remove CG varsParaGrid_test.cppextentandstartvariables intoModelArray'sDimensionSpecParaGrid_test.cppgetModelStatedumpModelStatewriteDiagnosticTimeConfigOutput_test.cppfor MPI buildsERA5/TOPAZtestsChange Description
After #331 added MPI parallelisation for thermodynamics on the RectGrid, this PR does the same for the Parametric grid. This should then check off the second task in #120 ("MPI parallelization of thermodynamics where all operations, except for I/O, are local to an MPI rank")
Test Description
ParaGrid_test.cpptests core functionality of ParaGrid (serial and MPI)./nextsim --config-file config_para24x30.cfgshould provide an integration test (serial and MPI) (based on Simple 2D ParametricGrid restart file #506)Further work (for a future PR)