Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConfigOutput.cpp #679

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andreapiacentini
Copy link

@andreapiacentini andreapiacentini commented Sep 3, 2024

Fixed default date

Fixes #678

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

The "zero" default date in

const std::string ConfigOutput::defaultLastOutput = "0-01-01T00:00:00Z";

cannot be parsed by my std library.
Replacing it by "0000-01-01T00:00:00Z" works just fine.


Test Description

Benchmark and all tests run.


Documentation Impact

N/A


Other Details

N/A


Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • File dates have been updated to reflect modification date
  • This change conforms to the conventions described in the README

Fixed default date
Format for parsing the year in isodates in the default LastOutput is %Y  In previous versions of std::get_time it requires 4 digits for the yyyy format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non universal date format in defaultLastOutput for ConfigOutput
3 participants