Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ancestral translation validation #1321

Closed

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented Sep 26, 2023

Description of proposed changes

Wasted some time trying to figure things out that would have been helped by better validation. So thought I'll give it a shot.

  • Checks pass
  • If making user-facing changes, add a message in CHANGES.md summarizing the changes in this PR

@corneliusroemer corneliusroemer force-pushed the improved-ancestral-translation-validation branch from fceff21 to 7b564b7 Compare September 26, 2023 03:49
@corneliusroemer corneliusroemer marked this pull request as ready for review September 26, 2023 03:49
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (2ec73cd) to head (7b564b7).
Report is 614 commits behind head on master.

Files with missing lines Patch % Lines
augur/ancestral.py 41.66% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
- Coverage   65.79%   65.74%   -0.05%     
==========================================
  Files          68       68              
  Lines        7151     7161      +10     
  Branches     1757     1762       +5     
==========================================
+ Hits         4705     4708       +3     
- Misses       2182     2185       +3     
- Partials      264      268       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@corneliusroemer
Copy link
Member Author

Don't really think this is that useful

@victorlin victorlin deleted the improved-ancestral-translation-validation branch November 15, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant