-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export v2: Automatically minify output #1352
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
+ Coverage 66.14% 66.23% +0.08%
==========================================
Files 68 68
Lines 7225 7238 +13
Branches 1777 1780 +3
==========================================
+ Hits 4779 4794 +15
+ Misses 2177 2176 -1
+ Partials 269 268 -1 ☔ View full report in Codecov by Sentry. |
01e6590
to
fb82a79
Compare
269dc25
to
0c994d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, where to set the default I don't mind so much, this isn't blocking for me as it can be changed easily.
483ff49
to
332ec39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good by inspection. UTF-8 does not use one byte all the time, it's 1 to 4 bytes, but for this purpose I think using characters and bytes interchangeably is ok.
@jameshadfield oh, good point! I'll push a fix to account for that. EDIT: pushed 50e71a3 |
Automatically format the output JSON file based on file size, unless either --minify-json or --no-minify-json (new option) is specified. Functional tests added to cover all code paths. Code to generate a Newick file was generated by ChatGPT.¹ ¹ <https://chat.openai.com/share/5f54c5fe-ee27-4691-bbb4-f71b63970770>
50e71a3
to
ab0f7bf
Compare
Description of proposed changes
Automatically format the output JSON file based on the number of tips, unless either --minify-json or --no-minify-json (new option) is specified.
Snippet of updated help output:
Related issue(s)
Checklist