-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tree): check for all synonyms of conflicting default args #1547
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
+ Coverage 72.27% 72.30% +0.03%
==========================================
Files 79 79
Lines 8273 8273
Branches 1691 1691
==========================================
+ Hits 5979 5982 +3
+ Misses 2009 2006 -3
Partials 285 285 ☔ View full report in Codecov by Sentry. |
Would be nice if someone could look at this, e.g. @huddlej @victorlin @tsibley @genehack @joverlee521 @jameshadfield |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @corneliusroemer! Nice to have the check for modern synonyms and also clearer to use those throughout the docs and tests (-czb
has always confused me, for example, and --polytomy
is much clearer).
IQtree2 has multiple synonyms for default args We were only checking for one of the synonyms. This PR fixes that. It also uses the currently preferred name for all IQtree options, where "preferred" is defined as the name shown in `iqtree2 -h` List of changes: `-nt` -> `-T` `--ntmax` -> `--threads-max` `-czb` -> `--polytomy` List of synonyms: `-ntmax`==`--threads-max` `-s`==`--aln`==`--msa` `-m`==`--model`
^ Conflicts: ^ CHANGES.md
96b0c04
to
9b9b864
Compare
-redo
to iqtree argsDescription of proposed changes
See commit messages for details.
Related issue(s)
Inspired by iqtree/iqtree2#273
Checklist