Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for xopen v1 #1692

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Drop support for xopen v1 #1692

merged 2 commits into from
Dec 9, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 5, 2024

Description of proposed changes

Following through with deprecation to simplify the code.

Related issue(s)

Follow-up to deprecation in #1532

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs
  • Post-merge: release this month as part of version 27.0.0

@victorlin victorlin self-assigned this Dec 5, 2024
@victorlin victorlin added the breaking Makes a backwards incompatible change and should wait for major release label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (037525d) to head (cc6d19a).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1692   +/-   ##
=======================================
  Coverage   72.30%   72.31%           
=======================================
  Files          79       79           
  Lines        8276     8271    -5     
  Branches     1691     1691           
=======================================
- Hits         5984     5981    -3     
+ Misses       2007     2005    -2     
  Partials      285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin victorlin marked this pull request as ready for review December 5, 2024 21:42
Following through with deprecation to simplify the code.
@victorlin victorlin force-pushed the victorlin/drop-xopen-v1 branch from 3e85a75 to cc6d19a Compare December 9, 2024 18:09
@victorlin victorlin merged commit ecce553 into master Dec 9, 2024
30 of 31 checks passed
@victorlin victorlin deleted the victorlin/drop-xopen-v1 branch December 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Makes a backwards incompatible change and should wait for major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants