Ensure all text files have end-of-file newlines #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing because the update of |
|
I was trying to minimally update ingest/vendored here without requiring this repo update to use |
A long-standing Unix convention that when broken can lead to confusing and incorrect behaviour from many commands when they read such files. The offending files in ingest/vendored will be fixed when we next update it from upstream. Updating it now would necessitate a slew of unrelated changes to this repo.
tsibley
force-pushed
the
trs/eof-newlines
branch
from
7b95385 to
a6c33c5
Compare
victorlin
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Let's check this on future PRs? We could use pre-commit's end-of-file-fixer (part of pathogen-repo-guide).
|
Sure, if you'd like. I don't want to set up pre-commit for this myself. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long-standing Unix convention that when broken can lead to confusing and incorrect behaviour from many commands when they read such files.
Checklist