Added API Action Request #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
dhurley
reviewed
Dec 19, 2024
| @@ -191,7 +191,28 @@ message ConfigUploadRequest { | |||
| } | |||
|
|
|||
| // Perform an associated API action on an instance | |||
There was a problem hiding this comment.
Can you add comments to the fields in the new proto messages?
There was a problem hiding this comment.
Can you add comments to all the fields like instance_id, http_upstream_name, servers, etc.
dhurley
reviewed
Dec 19, 2024
dhurley
reviewed
Dec 19, 2024
| @@ -191,7 +191,28 @@ message ConfigUploadRequest { | |||
| } | |||
|
|
|||
| // Perform an associated API action on an instance | |||
There was a problem hiding this comment.
Can you add comments to all the fields like instance_id, http_upstream_name, servers, etc.
dhurley
approved these changes
Dec 19, 2024
| var servers []client.UpstreamServer | ||
| res, err := json.Marshal(upstreams) | ||
| if err != nil { | ||
| slog.Error("Failed to marshal upstreams", "error", err, "servers", servers) |
There was a problem hiding this comment.
Suggested change
| slog.Error("Failed to marshal upstreams", "error", err, "servers", servers) | |
| slog.Error("Failed to marshal upstreams", "error", err, "upstreams", upstreams) |
oliveromahony
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added API Action Request ManagementPlaneRequest
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)