Do not set SELinux to permissive when it is enabled in check mode (#212)

nginxinc · Feb 15, 2022 · ac442ba · ac442ba
1 parent d9c0ae7
commit ac442ba
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -33,6 +33,7 @@ FEATURES:
 BUG FIXES:
 
 * Fix a bug when using a single `custom_directives` entry and the http template.
+* Fix check mode issue when running with SELinux enabled. Role no longer reports a change in check mode when setting the host to permissive mode.
 * Fix typo in the REST API template.
 * Fix incorrect REST API and status log variable names in [`defaults/main/template.yml`](https://github.com/nginxinc/ansible-role-nginx-config/blob/main/defaults/main/template.yml).
 * Fix bugged conditional check in the `http/ssl.j2` Jinja2 template.

diff --git a/tasks/prerequisites/setup-selinux.yml b/tasks/prerequisites/setup-selinux.yml
@@ -21,6 +21,7 @@
   selinux:
     state: permissive
     policy: targeted
+  when: not (ansible_check_mode and nginx_config_selinux_enforcing)
 
 - name: Allow SELinux HTTP network connections
   seboolean: