Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version in go.mod #1069

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Sep 18, 2023

Proposed changes

Problem: Go changed how the go directive works in Go 1.21. It now needs to be in the 1.21.x format.

go.dev/doc/toolchain#version
go.dev/ref/mod#go-mod-file-go

Solution: Update go.mod to add the patch version.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Go changed how the go directive works in Go 1.21. It now needs to be in the 1.21.x format.

go.dev/doc/toolchain#version
go.dev/ref/mod#go-mod-file-go
@lucacome lucacome requested a review from a team as a code owner September 18, 2023 17:59
@lucacome lucacome self-assigned this Sep 18, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file labels Sep 18, 2023
@lucacome lucacome merged commit 521398f into nginxinc:main Sep 18, 2023
22 checks passed
@lucacome lucacome deleted the chore/update-go-version branch September 18, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants