Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only write images to cache from the Build job #1701

Closed
wants to merge 1 commit into from

Conversation

lucacome
Copy link
Member

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added the chore Pull requests for routine tasks label Mar 15, 2024
@lucacome lucacome force-pushed the chore/build-cache branch from 57cc876 to cf52c43 Compare March 15, 2024 18:59
with:
version: latest
args: build --snapshot --clean
env:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it still be possible to use a separate NGF image with the configured telemetry parameters? this is needed for the functional test for telemetry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think this change needs to be reverted

@lucacome lucacome force-pushed the chore/build-cache branch 2 times, most recently from 2989750 to 634d313 Compare March 15, 2024 19:36
@lucacome lucacome force-pushed the chore/build-cache branch from 634d313 to c8b9a5b Compare March 15, 2024 19:38
@lucacome lucacome closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants