-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request header tutorial to how-to guides #2715
Conversation
✅ Deploy Preview will be available once build job completes!
|
105d451
to
3f40db7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 110 110
Lines 10913 10913
Branches 50 50
=======================================
Hits 9755 9755
Misses 1100 1100
Partials 58 58 ☔ View full report in Codecov by Sentry. |
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a lot of edit suggestions. Requesting changes so that the remaining sections are changed to fit the style of everything else (Remove informal language, add line breaks before headings, etc).
Since there are repeat steps for setting the headers application up, you can make setting it up its own section and refer back to it the second time- removes the redundancy, cuts down on the amount of text.
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
ad60c3e
to
37d3a0f
Compare
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more small things! LGTM.
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
site/content/how-to/traffic-management/request-response-headers.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Saylor Berman <[email protected]>
…s.md Co-authored-by: Saylor Berman <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
…s.md Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
bc7742d
to
05ed810
Compare
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users need a consolidated document for both request and response header modifiers
Solution: Updated existing response header modifier guide with request header modifier docs.
Testing: Testing using
make watch
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #2270
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.