feat: Update docs configuration for new logo #2867
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a prior commit, the Hugo theme for the documentation was updated. With that update, the new logo for NGINX Gateway Fabric was made available (Previously used for Service Mesh). This commit makes the necessary configuration changes for the new logo to be available: there is a paired pull request for the main documentation website.
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2867 +/- ##
=======================================
Coverage 89.86% 89.86%
=======================================
Files 107 107
Lines 10997 10997
Branches 50 50
=======================================
Hits 9883 9883
Misses 1054 1054
Partials 60 60 ☔ View full report in Codecov by Sentry. |
|
Can we also update https://github.com/nginxinc/nginx-gateway-fabric/blob/main/charts/nginx-gateway-fabric/chart-icon.png with the new logo? |
|
I'll push a change to write over the chart icon with the new image. I have a concurrent PR open for the main docs repo change, though I will not link it directly since it's a private repo that external users will not be able to follow. |
sjberman
approved these changes
Dec 5, 2024
ADubhlaoich
added a commit
to ADubhlaoich/ngf-doc-work
that referenced
this pull request
Dec 9, 2024
In a prior commit, the Hugo theme for the documentation was updated. With that update, the new logo for NGINX Gateway Fabric was made available (Previously used for Service Mesh). This commit makes the necessary configuration changes for the new logo to be available: there is a paired pull request for the main documentation website.
ADubhlaoich
added a commit
that referenced
this pull request
Dec 9, 2024
In a prior commit, the Hugo theme for the documentation was updated. With that update, the new logo for NGINX Gateway Fabric was made available (Previously used for Service Mesh). This commit makes the necessary configuration changes for the new logo to be available: there is a paired pull request for the main documentation website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In a prior commit, the Hugo theme for the documentation was updated. With that update, the new logo for NGINX Gateway Fabric was made available (Previously used for Service Mesh).
This commit makes the necessary configuration changes for the new logo to be available: there is a paired pull request for the main documentation website.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.