Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional tests for UpstreamSettings Policy #2869

Merged
merged 8 commits into from
Dec 20, 2024
Merged

Functional tests for UpstreamSettings Policy #2869

merged 8 commits into from
Dec 20, 2024
+943 −27

Conversation

salonichf5
Copy link
Contributor

@salonichf5 salonichf5 commented Dec 5, 2024 •
edited
Loading

Functional Tests for UpstreamSettings Policy.

Closes #2736

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Dec 5, 2024
@kate-osborn
Copy link
Contributor

@salonichf5 looks like you need to rebase on main

@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch 2 times, most recently from b4c4663 to a2d98fc Compare December 5, 2024 23:53
@salonichf5 salonichf5 changed the base branch from feature/upstream-settings-policy to main December 5, 2024 23:53
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch from a2d98fc to 829fbd4 Compare December 5, 2024 23:59
@github-actions github-actions bot added tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Dec 5, 2024
@salonichf5
Copy link
Contributor Author

@salonichf5 looks like you need to rebase on main

I rebased it from the feature branch for UpstreamSettings Policy to leverage the CRD for the functional tests and the base branch is the same as well

@salonichf5 salonichf5 marked this pull request as ready for review December 6, 2024 00:01
@salonichf5 salonichf5 requested review from a team as code owners December 6, 2024 00:01
@kate-osborn
Copy link
Contributor

kate-osborn commented Dec 6, 2024 •
edited
Loading

@salonichf5 looks like you need to rebase on main

I rebased it from the feature branch for UpstreamSettings Policy to leverage the CRD for the functional tests and the base branch is the same as well

@salonichf5
Sorry, I didn't look closely at your changes, I just saw that you had a bunch of other commits.

We want to target the upstream settings policy branch for this PR, not main. Sorry for the confusion.

@salonichf5 salonichf5 changed the base branch from main to feature/upstream-settings-policy December 6, 2024 00:42
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch from 829fbd4 to 1b13c21 Compare December 9, 2024 17:44
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Dec 9, 2024
kate-osborn
kate-osborn requested changes Dec 9, 2024
View reviewed changes
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/suite/manifests/upstream-settings-policy/invalid-usps.yaml Outdated Show resolved Hide resolved
tests/suite/manifests/upstream-settings-policy/invalid-usps.yaml Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/manifests/upstream-settings-policy/valid-usps.yaml Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
kate-osborn
kate-osborn requested changes Dec 9, 2024
View reviewed changes
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
@ADubhlaoich ADubhlaoich removed the request for review from a team December 10, 2024 13:03
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch from b69c193 to 37d91e4 Compare December 11, 2024 18:37
kate-osborn
kate-osborn requested changes Dec 11, 2024
View reviewed changes
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch 2 times, most recently from 723d1c6 to ca42375 Compare December 19, 2024 17:43
sjberman
sjberman reviewed Dec 19, 2024
View reviewed changes
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
tests/framework/crossplane.go Outdated Show resolved Hide resolved
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch from 05cb89f to 17f5a7c Compare December 20, 2024 02:43
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch 4 times, most recently from 054e73c to bb30486 Compare December 20, 2024 17:14
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch from bb30486 to 6e267ea Compare December 20, 2024 17:23
kate-osborn
kate-osborn requested changes Dec 20, 2024
View reviewed changes
tests/suite/upstream_settings_test.go Show resolved Hide resolved
tests/suite/upstream_settings_test.go Show resolved Hide resolved
tests/suite/upstream_settings_test.go Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
sjberman
sjberman reviewed Dec 20, 2024
View reviewed changes
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Outdated Show resolved Hide resolved
tests/suite/upstream_settings_test.go Show resolved Hide resolved
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch 2 times, most recently from 722bf2a to d33da67 Compare December 20, 2024 19:23
@salonichf5 salonichf5 requested a review from sjberman December 20, 2024 19:25
@salonichf5 salonichf5 force-pushed the tests/upstream-functional branch from d33da67 to 3d09142 Compare December 20, 2024 19:53
kate-osborn
kate-osborn approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@salonichf5 salonichf5 merged commit 48ecf2e into nginxinc:feature/upstream-settings-policy Dec 20, 2024
37 checks passed
kate-osborn pushed a commit to kate-osborn/nginx-gateway-fabric that referenced this pull request Dec 20, 2024
@salonichf5 @kate-osborn
Functional tests for UpstreamSettings Policy (nginxinc#2869)
a8120ca 
Functional Tests for UpstreamSettings Policy.
kate-osborn pushed a commit that referenced this pull request Dec 20, 2024
@salonichf5 @kate-osborn
Functional tests for UpstreamSettings Policy (#2869)
b0ed7e2 
Functional Tests for UpstreamSettings Policy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functional Test for Upstream Settings
3 participants
@salonichf5 @kate-osborn @sjberman