Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cherrypick) feat: Update docs configuration for new logo (#2867) #2880

Merged

Conversation

ADubhlaoich
Copy link
Contributor

Proposed changes

In a prior commit, the Hugo theme for the documentation was updated. With that update, the new logo for NGINX Gateway Fabric was made available (Previously used for Service Mesh).

This commit makes the necessary configuration changes for the new logo to be available: there is a paired pull request for the main documentation website.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


In a prior commit, the Hugo theme for the documentation was updated.
With that update, the new logo for NGINX Gateway Fabric was made
available (Previously used for Service Mesh).

This commit makes the necessary configuration changes for the new logo
to be available: there is a paired pull request for the main
documentation website.
@ADubhlaoich ADubhlaoich requested review from a team as code owners December 9, 2024 15:25
@github-actions github-actions bot added documentation Improvements or additions to documentation helm-chart Relates to helm chart labels Dec 9, 2024
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) December 9, 2024 15:25
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (a890a8b) to head (10a114e).
Report is 1 commits behind head on release-1.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #2880   +/-   ##
============================================
  Coverage        89.86%   89.86%           
============================================
  Files              107      107           
  Lines            10997    10997           
  Branches            50       50           
============================================
  Hits              9883     9883           
  Misses            1054     1054           
  Partials            60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ADubhlaoich ADubhlaoich merged commit 1ebaa55 into nginxinc:release-1.5 Dec 9, 2024
49 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/pick-update-logo branch December 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants