Add UpstreamSetttingsPolicy #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Problem: Users want to configure the behavior of the connection between NGINX and their upstream applications. Solution: Add the UpstreamSettingsPolicy CRD, which is a direct policy that will attach to a Service that is referenced in an HTTPRoute or GRPCRoute. Testing: Tested that validation works.
Translate data plane intermediary UpstreamSettingsPolicy configuration into NGINX configuration. Problem: I want the data plane configuration generated from my UpstreamSettingsPolicy to be translated into NGINX Configuration. Solution: Translate the data plane UpstreamSettingsPolicy configuration into NGINX configuration. Testing: Unit tests.
…tion (#2887) Problem: As a userI want NGF to take my configuration for an UpstreamSettingsPolicy and transform it into data plane configuration within NGF, so that NGF can then translate those settings into NGINX configuration, and so that NGF maintains an abstraction layer between data plane configuration and the specific data plane NGF uses. Solution: Add controller to watch UpstreamSettingsPolicies, and store them in the cluster state as generic NGF Policies. Update the graph to validate and process these policies and attach them to the relevant Services. When building the dataplane configuration, store the policies on the relevant http upstreams.
Problem: Want to collect number of UpstreamSettingsPolicies in cluster. Solution: Collect the count of UpstreamSettingsPolicies in cluster.
Problem: When an UpstreamSettingsPolicy targeted multiple Services, NGF would write duplicate ancestors to its status. Solution: Only add unique ancestors to policy ancestors list.
Functional Tests for UpstreamSettings Policy.
kate-osborn
force-pushed
the
feature/upstream-settings-policy
branch
from
a8120ca to
b0ed7e2
Compare
✅ Deploy Preview will be available once build job completes!
|
sjberman
approved these changes
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
==========================================
+ Coverage 89.74% 89.93% +0.18%
==========================================
Files 109 111 +2
Lines 11150 11421 +271
Branches 50 50
==========================================
+ Hits 10007 10271 +264
- Misses 1083 1089 +6
- Partials 60 61 +1 ☔ View full report in Codecov by Sentry. |
|
@kate-osborn When merging, can you make sure @bjee19 and @salonichf5 are also listed as contributors? Everyone deserves their credit :) |
Of course! Thanks for the reminder |
salonichf5
approved these changes
Dec 20, 2024
sjberman
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a user, I want to be able to configure the upstream settings for a Service referenced by a HTTP or GRPCRoute.
Solution: Add UpstreamSettingsPolicy CRD. This is a direct policy that can be attached to one or more Services.
The Service must be referenced by an HTTP or GRPCRoute that is owned by the "winning" NGF Gateway.
Testing: Unit, manual, and automated functional tests.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.