Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fonts when copying/moving retail data #213

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Include fonts when copying/moving retail data #213

wants to merge 2 commits into from

Conversation

jg18
Copy link
Collaborator

@jg18 jg18 commented Oct 11, 2020

This PR should fix issue #211 .

However, getting it to work properly will require PR #212 because creating NSIS installers is currently broken in develop.

Still needs testing, will do that later.

@jg18
Copy link
Collaborator Author

jg18 commented Oct 11, 2020

Passes manual test when copying from a retail installation of the Polish version.

But fails when using an installer file. I bet that what's going on is that Knossos is trying to move the font files twice, because I tried to compensate for case-sensitive file systems. I'll look into fixing this.

@Goober5000
Copy link
Collaborator

@jg18 Be advised the English font files do have the lower-case .vf extension.

@jg18
Copy link
Collaborator Author

jg18 commented Oct 12, 2020

Ok, how about this: since *.VF should work fine in case-insensitive file systems, and since generally only Linux uses case-sensitive, I’ll add something to the effect of “if we’re on Linux, look for .vf files in the fonts folder in addition to .VF files.” Basically reverting my last commit but limiting to Linux.

@Goober5000
Copy link
Collaborator

Is it not possible to first grab a list of the files and then do the file operations?

This is the problem I ran into with the FSO Installer: it might see MediaVPs, or mediavps, or MEDIAVPS. Since there was no way to tell which format someone would use, I had to assemble my own case-insensitive list of files or folders, do a case-insensitive check for whatever was present on the file system, and only then do the file operations.

It was obviously quite a bit more work, but it was the only way to ensure reliable cross-platform, cross-mod file management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants