Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crypto does not work in http domain (specs) #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nuriddin2468
Copy link

@nuriddin2468 nuriddin2468 commented Apr 23, 2024

Removing crypto package for generating uuid

What kind of change does this PR introduce?

Generating uuid now works without "crypto" package.

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

While domain is working under HTTP , crypto does not exist, so it throws an error randomUUID function not found.

Source: click

Issue Number: N/A

What is the new behavior?

Now it generated uuid without crypto, so in HTTP domain it works fine

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

stackblitz bot commented Apr 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuriddin2468
Copy link
Author

@NetanelBasal up pls.

@NetanelBasal
Copy link
Member

I don't see any reason to work with HTTP. I'm willing to merge a PR that accepts a custom function to generate the id, but we don't need this code in our bundle :)

@nuriddin2468
Copy link
Author

During the development phase, we encountered challenges when testing certain features due to the necessity of using private endpoints. Unfortunately, this incompatibility led to disruptions in most of the library's dialog functionalities related to cryptographic specifications. But , we have already transitioned to our self-made workaround. I can close merge request if there is no need to this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants