Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NPM and Webpack configuration to overcome installation errors #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ltfschoen
Copy link

@ltfschoen ltfschoen commented Nov 8, 2016

Updated NPM dependencies and Webpack config to so can just run npm install without encountering installation any major errors that I encountered such as the following:

$ npm install
npm WARN [email protected] requires a peer of react@* but none was installed.
npm WARN [email protected] requires a peer of react-dom@* but none was installed.

$ npm run serve
sh: webpack-dev-server: command not found

$ npm install -g webpack-dev-server
npm WARN [email protected] requires a peer of webpack@>=1.3.0 <3 but none was installed.
npm WARN [email protected] requires a peer of webpack@1 || ^2.1.0-beta but none was installed.
...
Error: Cannot find module 'webpack'
Error: Cannot find module 'babel-polyfill'
ERROR in multi main
Module not found: Error: Cannot resolve module 'babel' 
...
ERROR in ./src/js/app.js
Module not found: Error: Cannot resolve module 'aframe'
...

@reidblomquist
Copy link

reidblomquist commented Nov 13, 2016

+1 - just updated my fork to latest master and tried running yarn and am running into the peer dependency errors (able to run serve - but yeh...)

update: just merged @ltfschoen's branch with these changes and ran with yarn - everything works fine! contemplating opening a pr that uses webpack-dashboard for dev if that sounds like a nicety maintainers would like.

@@ -8,7 +8,11 @@
"aframe-bmfont-text-component": "^0.1.4",
"aframe-react": "^3.4.0",
"aframe-text-component": "^0.3.0",
"babel-polyfill": "^6.3.14"
"graceful-fs": "^4.1.10",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's graceful/lodash/minimatch for?

@@ -0,0 +1,4 @@
{
"plugins": ["syntax-jsx"],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can format

{
  plugins: ['syntax-jsx'],
  presets: ['es2015', 'react', 'babel-preset-stage-0']
}

@nobodysfool
Copy link

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants