Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : input & output signal migration #25

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat : input & output signal migration #25

wants to merge 5 commits into from

Conversation

mohan-mu
Copy link

No description provided.

@mohan-mu
Copy link
Author

mohan-mu commented Oct 23, 2024 •
edited
Loading

hi @shhdharmen , Please Validate this PR .

@mohan-mu mohan-mu marked this pull request as draft October 23, 2024 08:30
@mohan-mu mohan-mu marked this pull request as ready for review October 23, 2024 08:47
@mohan-mu
Copy link
Author

mohan-mu commented Oct 23, 2024 •
edited
Loading

Problem To be looked at :

Investigate how to migrate defaultConfig

hot-toast/projects/ngxpert/hot-toast/src/lib/components/hot-toast-container/hot-toast-container.component.ts

Line 28 in 39347a7

@Input() defaultConfig: ToastConfig;

Because

hot-toast/projects/ngxpert/hot-toast/src/lib/hot-toast.service.ts

Line 57 in 39347a7

this._componentRef.setInput('defaultConfig', this._defaultGlobalConfig);
sets Input via @ngneat/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mohan-mu