Annotations extensions #636
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.GetDefaultGenerator: Try apply DatabaseGeneratedAttribute. 2.Map: Try apply RequiredAttribute, MaxLengthAttribute.
Map: Try apply RequiredAttribute, MaxLengthAttribute.
Upgrade <TargetFrameworks>net6.0</TargetFrameworks>
IsId: return true when [Key] present on member.
<PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" />
hazzik
requested changes
Mar 26, 2024
| <ItemGroup> | ||
| <PackageReference Include="NHibernate" Version="5.3.3" /> | ||
| <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0" /> |
There was a problem hiding this comment.
Sorry, but I don't think I can accept this as a dependency.
| { | ||
| private static INHibernateLogger Log { get; set; } | ||
|
|
||
| private static void UsingLog(Action<INHibernateLogger> log) |
There was a problem hiding this comment.
This seems to be completely unrelated to the proposed changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Upgrade FluentNHibernate.csproj, Add TargetFrameworks net6.0.
Reference System.ComponentModel.Annotations.
Set ColumnMapping.NotNull when [Required] present or not GetType().IsNullable().
Set ColumnMapping.Length when [MaxLength] present.
Configure GeneratorMapping.Class to [assinged] when [DatabaseGenerated(DatabaseGeneratedOption.None)] present.
Configure GeneratorMapping.Class to [identity] when [DatabaseGenerated(DatabaseGeneratedOption.Identity)] present.
3.Update DefaultAutomappingConfiguration.cs.
IsId: return true when [Key] present on member.
4.Update IdentityStep.cs.
Support [DatabaseGenerated(DatabaseGeneratedOption.None)]
Support [DatabaseGenerated(DatabaseGeneratedOption.Identity)]
5.Update PropertyStep.cs.
Support [MaxLength], [Required], or GetType().IsNullable().