Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - DM convert refactor #486

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP - DM convert refactor #486

wants to merge 1 commit into from

Conversation

blowekamp
Copy link
Collaborator

Refactor the dm_convert pipeline.

Create a function to convert mrc to tiff files with newstack

Replace dm->jpeg step with newstack function.

Move separate "conditional" tasks into one function.

Addresses (eg: #1)

Depends on (eg: #1)

Changes

  • List of changes
  • Breaking changes
  • Changes to configurations

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

Refactor the dm_convert pipeline.

Create a function to convert mrc to tiff files with newstack

Replace dm->jpeg step with newstack function.

Move separate "conditional" tasks into one function.
@blowekamp blowekamp requested a review from philipmac November 5, 2024 14:29
@blowekamp blowekamp changed the title WIP WIP - DM convert refactor Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant