Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #34

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add types #34

merged 1 commit into from
Nov 5, 2024

Conversation

mjlehrke
Copy link
Contributor

@mjlehrke mjlehrke commented Nov 4, 2024

I believe this is all that is needed for typing this plugin.

@nickdeis
Copy link
Owner

nickdeis commented Nov 5, 2024

Hey @mjlehrke,
Thank you! Moving more of my repos over to typescript is on my 2025 todo list, and I completely forgot this was an option. I'll look more into this, there might be some generics I can add options to.
I get this published as soon as possible though!
Thanks,
Nick

@nickdeis nickdeis merged commit da1fc61 into nickdeis:master Nov 5, 2024
2 checks passed
@nickdeis
Copy link
Owner

nickdeis commented Nov 5, 2024 •
edited
Loading

Hey @mjlehrke,
I've released these changes into to the most recent version (1.1.2). Thank you for your help and please let me know if you run into any issues.
Best,
Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjlehrke @nickdeis