Skip to content

Commit

Permalink
LibWeb: Refer a spec issue in Location::internal_get_own_property
Browse files Browse the repository at this point in the history
(cherry picked from commit 4cd1ef12d7bdddc7cbb235350d50fee65fbd5f34)
  • Loading branch information
shlyakpavel authored and nico committed Dec 21, 2024
1 parent 267b55e commit 6f01d38
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Userland/Libraries/LibWeb/HTML/Location.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ JS::ThrowCompletionOr<Optional<JS::PropertyDescriptor>> Location::internal_get_o
auto descriptor = MUST(Object::internal_get_own_property(property_key));

// 2. If the value of the [[DefaultProperties]] internal slot of this contains P, then set desc.[[Configurable]] to true.
// FIXME: This doesn't align with what the other browsers do. Spec issue: https://github.com/whatwg/html/issues/4157
auto property_key_value = property_key.is_symbol()
? JS::Value { property_key.as_symbol() }
: JS::PrimitiveString::create(vm, property_key.to_string());
Expand Down

0 comments on commit 6f01d38

Please sign in to comment.