-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install system-images of additional Android versions #20 #28
base: main
Are you sure you want to change the base?
Conversation
@@ -24,6 +24,7 @@ | |||
"url": "git+https://github.com/nightwatchjs/mobile-helper-tool" | |||
}, | |||
"devDependencies": { | |||
"@nightwatch/mobile-helper": "^0.1.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should not include this dependency. This dependency points to this same repository.
Once removed run npm install
, so package-lock.json can be restored to its original state.
@@ -0,0 +1,77 @@ | |||
|
|||
## | |||
Install system-images of additional Android versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text should be along with ##
like ## Install system-images......
.
Remove the new line before the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting of the file added by you is not very good, can you fix it? See https://github.com/An-Yay/mobile-helper-tool/blob/main/docs/Install_System_Images_of_Android.md
Please refer to #31 to see how to format the file.
|
||
``` | ||
|
||
This command displays all available SDK packages you can install or update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also briefly explain what all the different system images mean. Like the difference between Google APIs system image vs Google Play system image; ARM vs Intel; etc. and which system image to install in which case.
You can also add a link if you find a good resource to follow regarding this.
**2. Installing System Images:** | ||
|
||
``` | ||
sdkmanager --install "system-images;android-30;google_apis;x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention it as sdkmanager --install "<system-image-id>"
and then mention the above as an example.
**1. Listing Available SDK Packages:** | ||
|
||
``` | ||
sdkmanager --list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sdkmanager
would not work directly on majority of systems. Also mention the steps on how to go to the location where sdkmanager
binary is present and how to run it. Or maybe we need to add the binaries location to PATH. The same goes for avdmanager
.
Also, on Windows, I think we need to use sdkmanager.exe
to run it, please verify the same.
Kindly review the given steps for installing and deleting new versions of Android #20 . Do let me know of any improvements or changes on the same.
Regards,
Ananay