Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add Vite v5 to peerDeps #11

Closed
wants to merge 1 commit into from

Conversation

ayushmanchhabra
Copy link
Contributor

@ayushmanchhabra ayushmanchhabra commented Aug 14, 2024

This PR allows installing @nightwatch/react package in projects where Vite v5 is already installed. Below is the error message encountered when trying to install the package without the changes in this PR.

$: npm i -D @nightwatch/react
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/vite
npm error   dev vite@"^5.4.0" from the root project
npm error   peer vite@"^4.2.0 || ^5.0.0" from @vitejs/[email protected]
npm error   node_modules/@vitejs/plugin-react
npm error     dev @vitejs/plugin-react@"^4.3.1" from the root project
npm error     peer @vitejs/plugin-react@"^4.0.4" from @nightwatch/[email protected]
npm error     node_modules/@nightwatch/react
npm error       dev @nightwatch/react@"*" from the root project
npm error
npm error Could not resolve dependency:
npm error peer vite@"^4.0.4" from @nightwatch/[email protected]
npm error node_modules/@nightwatch/react
npm error   dev @nightwatch/react@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

After merging this, I'll take a shot at getting this to work with the latest nightwatch version

@ayushmanchhabra ayushmanchhabra marked this pull request as draft August 14, 2024 20:29
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review August 14, 2024 20:34
@ayushmanchhabra ayushmanchhabra marked this pull request as draft August 15, 2024 16:31
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review August 15, 2024 16:47
@ayushmanchhabra ayushmanchhabra marked this pull request as draft August 15, 2024 18:33
@ayushmanchhabra ayushmanchhabra marked this pull request as ready for review August 16, 2024 16:49
@ayushmanchhabra
Copy link
Contributor Author

/cc: @AutomatedTester @beatfactor this is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant