Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example google.js failed due to changes in website #9

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

uditrajput03
Copy link
Contributor

Fixed nightwatchjs/nightwatch#4106
image

What is done:

  • Fixed menu selector
  • Changed general menuXpath
  • Changed 'all' with 'maps' as all removed from website menu (menu's element all has been removed from the website hence updated it with another element maps)

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Can you do these changes in the main Nightwatch repo as well (in the examples directory)?

@garg3133 garg3133 merged commit 39ee877 into nightwatchjs:main Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example with-page-object of Google failed due to some changes in website
2 participants