This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
[WIP] T fcontarst cleaning #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bthirion
force-pushed
the
tFcontarst-cleaning
branch
from
d8f43d2 to
7037cf6
Compare
kchawla-pi
reviewed
Nov 29, 2018
| @@ -45,7 +46,7 @@ def __init__(self, theta, Y, model, cov=None, dispersion=1., nuisance=None, | |||
| multiplicative factor in front of `cov` | |||
|
|
|||
| nuisance : None of ndarray | |||
| parameter estimates needed to compute logL | |||
| parameter estimates needed to compute log-lokelohood | |||
|
If you are removing unused or obviateable code then that's good. |
|
What's the status on this? |
|
This is meant to remove a large part of the code base that is not great (over-designed). I can try and revive it. |
|
Indeed. This seems like an important one before we incorporate this into Nilearn. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a massive code simplification. We should decide whether we want it or not.