share locals between branches, from review feedback

niloc132 · Dec 14, 2024 · 7b46ff4 · 7b46ff4
1 parent bae93b4
commit 7b46ff4
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java b/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java
@@ -545,15 +545,13 @@ public void endVisit(BreakStatement x, BlockScope scope) {
     @Override
     public void endVisit(YieldStatement x, BlockScope scope) {
       try {
+        SourceInfo info = makeSourceInfo(x);
+        JExpression expression = pop(x.expression);
         if (x.switchExpression == null) {
           // This is an implicit 'yield' in a case with an arrow - synthesize a break instead and
           // wrap with a block so that the child count in JDT and GWT matches.
-          SourceInfo info = makeSourceInfo(x);
-          JExpression pop = pop(x.expression);
-          push(new JBlock(info, pop.makeStatement(), new JBreakStatement(info, null)));
+          push(new JBlock(info, expression.makeStatement(), new JBreakStatement(info, null)));
         } else {
-          SourceInfo info = makeSourceInfo(x);
-          JExpression expression = pop(x.expression);
           push(new JYieldStatement(info, expression));
         }
       } catch (Throwable e) {