Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoItem::validateTitle return a boolean instead of the value #45

Open
anthonykozak opened this issue Apr 10, 2017 · 2 comments · May be fixed by #48
Open

VideoItem::validateTitle return a boolean instead of the value #45

anthonykozak opened this issue Apr 10, 2017 · 2 comments · May be fixed by #48

Comments

@anthonykozak
Copy link

return self::validateString($title) && \strlen($title) < 97;

self::validateString($title) returns the value as expected, but the whole line will return a boolean which gives a wrong value in the generated sitemap.
@nilportugues
Copy link
Owner

@anthonykozak mind sharing with me the file so I can fix it? 👍 :)

@anthonykozak
Copy link
Author

anthonykozak commented Apr 10, 2017 via email •
edited
Loading

@murdinc murdinc linked a pull request Jan 14, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes video title validator murdinc/php-sitemap
2 participants
@nilportugues @anthonykozak