Fixes video title validator #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Feb 7, 2019
src/Item/Video/VideoItem.php
Outdated
| $loc, | ||
| $playerEmbedded, | ||
| $playerAutoPlay | ||
| ); |
|
The Travis CI build is failed due to failed assertion. The error message is as follows: I think this test should be fixed/concerned. |
peter279k
reviewed
Oct 29, 2019
| @@ -65,11 +65,16 @@ public function validateThumbnailLoc($loc) | |||
| /** | |||
| * @param $title | |||
| * | |||
| * @return bool | |||
| * @return string|false | |||
There was a problem hiding this comment.
I think the return annotation should be type hint.
That is, it should be string|bool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
Updates VideoItemValidator:: validateTitle() to return the video title instead of true when the video title is the correct length, and false when it is too long or empty.