allow for custom domain in k8s-nameserver #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrox
reviewed
Dec 3, 2024
| @@ -75,6 +75,10 @@ type DNSConfigSpec struct { | |||
| // Tailscale Ingresses. The operator will always deploy this nameserver | |||
| // when a DNSConfig is applied. | |||
| Nameserver *Nameserver `json:"nameserver"` | |||
| // Domain is the domain for which DNS entries will be resolved. | |||
| // Defaults to ts.net if empty. | |||
There was a problem hiding this comment.
The flag in the nameserver defaults to ts.net but here it does not so this comment is not super accurate. Maybe a kubebuilder default here would make sense?
There was a problem hiding this comment.
I was thinking about this, but I didn't see any kubebuilder default annotation used in any other type file. That is why I went without. I could change the comment to
If left empty, the default of the k8s-nameserver will be used.
?
There was a problem hiding this comment.
Furthermore the domain is currently defined by the control-server and by the k8s-nameserver, but the k8s-operator is quite domain agnostic. The "ts.net" domain is only used in test files.
There was a problem hiding this comment.
If left empty, the default of the k8s-nameserver will be used.
Fine with me
Pull Request Test Coverage Report for Build 12138963348Details
💛 - Coveralls |
This allows for a custom domain in the k8s-nameserver application. It can be set via an argument to the binary and will default to ts.net if not set.
thirdeyenick
force-pushed
the
custom-dns-domain
branch
from
7698ffa to
1658054
Compare
ctrox
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to have a custom magicDNS domain for the k8s-nameserver.