Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase, add basic test #731

Closed

Conversation

bpinsard
Copy link
Contributor

No description provided.

@bpinsard bpinsard changed the base branch from enh-custom-seqinfo to master January 16, 2024 16:11
@bpinsard bpinsard changed the base branch from master to enh-custom-seqinfo January 16, 2024 16:12
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (d798b12) 81.88% compared to head (fe9f918) 82.02%.
Report is 10 commits behind head on enh-custom-seqinfo.

❗ Current head fe9f918 differs from pull request most recent head 86e35c7. Consider uploading reports for the commit 86e35c7 to get more accurate results

Files Patch % Lines
heudiconv/main.py 53.84% 6 Missing ⚠️
heudiconv/dicoms.py 76.47% 4 Missing ⚠️
heudiconv/heuristics/example.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           enh-custom-seqinfo     #731      +/-   ##
======================================================
+ Coverage               81.88%   82.02%   +0.14%     
======================================================
  Files                      41       41              
  Lines                    4117     4178      +61     
======================================================
+ Hits                     3371     3427      +56     
- Misses                    746      751       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

something went wrong with rebase I guess...

@bpinsard
Copy link
Contributor Author

Yes, tried to rebase, if I open the PR to master it shows commits correctly, but not when opening to enh-custom-seqinfo.
Maybe if nipy branch get rebased first it will fix the issue.

@yarikoptic yarikoptic added the minor Increment the minor version when merged label Jan 16, 2024
@yarikoptic
Copy link
Member

I have rebased #581 now, invited you to join our heudiconv team so you could push directly into that PR (just never push to master please ;) )

@bpinsard
Copy link
Contributor Author

Great, should we add a branch protection rule for master?

@bpinsard bpinsard closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants