-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase, add basic test #731
Conversation
…itrary value Just a draft implementation
fe9f918
to
86e35c7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## enh-custom-seqinfo #731 +/- ##
======================================================
+ Coverage 81.88% 82.02% +0.14%
======================================================
Files 41 41
Lines 4117 4178 +61
======================================================
+ Hits 3371 3427 +56
- Misses 746 751 +5 ☔ View full report in Codecov by Sentry. |
something went wrong with rebase I guess... |
Yes, tried to rebase, if I open the PR to master it shows commits correctly, but not when opening to enh-custom-seqinfo. |
7d3b287
to
df4e0bf
Compare
I have rebased #581 now, invited you to join our heudiconv team so you could push directly into that PR (just never push to master please ;) ) |
Great, should we add a branch protection rule for master? |
No description provided.