-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/cord-nvim: init #2408
base: main
Are you sure you want to change the base?
plugins/cord-nvim: init #2408
Conversation
don't feel obligated to add all the options, you can simply add options that are likely to be used by all users of this plugin |
error: build of '/nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv' on 'ssh-ng://[email protected]' failed: builder for '/nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv' failed with exit code 1;
last 9 log lines:
> ERROR: Error detected while processing /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:
> E5113: Error while calling lua chunk: /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:9: module 'cord-nvim' not found:
> no field package.preload['cord-nvim']
> no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/share/lua/5.1/cord-nvim.lua'
> no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/share/lua/5.1/cord-nvim/init.lua'
> no file '/nix/store/h25v2irfigii5xby44ff7jwfj5sfh06d-luajit-2.1.1713773202-env/lib/lua/5.1/cord-nvim.so'
> stack traceback:
> [C]: in function 'require'
> /nix/store/80ylygcwnlkhbmwysfpygb01sbs10p6z-init.lua:9: in main chunk
For full logs, run 'nix log /nix/store/d7pw4yq7y1bc28l12kf8lkmms7nr8pkr-defaults.drv'. |
Yeah still can't figure out how to fix the issue. |
Ops. |
Sorry, I edited my suggestion, Didn't mean to remove the originalName |
28e793e
to
177cfbe
Compare
Dropped the commit. |
Well I am trying to add all of the options but it shouldn't be too hard to manage as options hasn't been changed in ages. |
9aa69f5
to
1e28fd2
Compare
I will work on more of the options tmr I need to sleep. |
I didn't have time today but I will look into add more options asap. |
Just to clarify, the reason we don't need to declare all upstream options is that That means users can configure anything under In fact, any options declared actually add additional restrictions due to their type checking. So when we do declare options we must ensure the type is permissive enough to allow users to configure anything upstream may allow. |
Co-authored-by: Austin Horstman <[email protected]>
Co-authored-by: Austin Horstman <[email protected]> plugins/cord-nvim: fix duplicates and formatting
Hey @khaneliman Is it normal for docs not building manual using the Logs:
Cause I am building docs manually to see where I need to improve. |
If you're on darwin (OSX) then we disable the docs because mdbook has an upstream issue. Otherwise no, that could be a bug.
|
I am on |
but also what issue is on darwin cause I want to debug the issue as I have a darwin machine. |
You can see in Lines 68 to 90 in 3c7b6ae
I'm not too familiar, but it's an upstream issue. If you do want to look into that, let's deal with it in another issue as I don't want it to distract from landing the changes here. |
Also would that be a bug? |
I'm able to serve-docs on main and this branch. |
Weird for some reason it fails. |
1e28fd2
to
bbc2152
Compare
Both this branch and upstream are not working on |
I have made an issue on their end to see if they can fix it. |
I am going to work on getting the options finished then sqrash then it will be ready to review. |
Co-authored-by: Gaétan Lepage <[email protected]>
Adds the
cord-nvim
plugin.For more info view the plugin homepage: https://github.com/vyfor/cord.nvim.
fixes: #2373
Note: It's work in progress as I need to do most of the options